StevenJW/x-lab-lbq-technical-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix spelling in readme

Browse Source
This commit is contained in:
Stedoss 2022-11-01 02:27:01 +00:00
parent 8ebf9dca96
commit 38bedbaa72
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
README.md
View File

@ -1,7 +1,7 @@
# x-lab-lbq # x-lab-lbq
## Overview ## Overview
This is a very simple implementation of a standard datafetching backend-frontend piece. It may seem very simple and not very feature rich (and look quick ugly!), however I feel like it's a good representation of the approches I would take to a brand new full stack application, without implementing all of the future features. This is a very simple implementation of a standard datafetching backend-frontend piece. It may seem very simple and not very feature rich (and look quick ugly!), however I feel like it's a good representation of the approaches I would take to a brand new full stack application, without implementing all of the future features.
It shows the CSV data given as a simple grid, where the user can filter based on tags and categories. It shows the CSV data given as a simple grid, where the user can filter based on tags and categories.
@ -95,7 +95,7 @@ This will produce a build that can be deployed (sorry for no instructions on dep
#### Environment Settings #### Environment Settings
The `./frontend/leeds-beer-quest/src/lib/environment.ts` file should already contain the correct location for the backend API, however if it does not you should modify the `BaseAPIUrl` property to be the same path as your backend instance. The `./frontend/leeds-beer-quest/src/lib/environment.ts` file should already contain the correct location for the backend API, however if it does not, you should modify the `BaseAPIUrl` property to be the same path as your backend instance.
## How can I improve? ## How can I improve?
@ -113,7 +113,7 @@ Only unit tests are included, which are good however integration and automated t
### DTOs ### DTOs
Returning raw database objects as responses isn't really ideal (and I found an issue with many-to-many relationships which causes an infinte loop in the JSON parser!), so it would be ideal to use DTOs when returning objects from the API. Returning raw database objects as responses isn't really ideal (and I found an issue with many-to-many relationships which causes an infinite loop in the JSON parser!), so it would be ideal to use DTOs when returning objects from the API.
### More and better configuration ### More and better configuration