From 38bedbaa72f1b5efc3ef9b7d6b16afb2ace792de Mon Sep 17 00:00:00 2001 From: Stedoss <29103029+Stedoss@users.noreply.github.com> Date: Tue, 1 Nov 2022 02:27:01 +0000 Subject: [PATCH] Fix spelling in readme --- README.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index c476b99..a125187 100644 --- a/README.md +++ b/README.md @@ -1,7 +1,7 @@ # x-lab-lbq ## Overview -This is a very simple implementation of a standard datafetching backend-frontend piece. It may seem very simple and not very feature rich (and look quick ugly!), however I feel like it's a good representation of the approches I would take to a brand new full stack application, without implementing all of the future features. +This is a very simple implementation of a standard datafetching backend-frontend piece. It may seem very simple and not very feature rich (and look quick ugly!), however I feel like it's a good representation of the approaches I would take to a brand new full stack application, without implementing all of the future features. It shows the CSV data given as a simple grid, where the user can filter based on tags and categories. @@ -95,7 +95,7 @@ This will produce a build that can be deployed (sorry for no instructions on dep #### Environment Settings -The `./frontend/leeds-beer-quest/src/lib/environment.ts` file should already contain the correct location for the backend API, however if it does not you should modify the `BaseAPIUrl` property to be the same path as your backend instance. +The `./frontend/leeds-beer-quest/src/lib/environment.ts` file should already contain the correct location for the backend API, however if it does not, you should modify the `BaseAPIUrl` property to be the same path as your backend instance. ## How can I improve? @@ -113,7 +113,7 @@ Only unit tests are included, which are good however integration and automated t ### DTOs -Returning raw database objects as responses isn't really ideal (and I found an issue with many-to-many relationships which causes an infinte loop in the JSON parser!), so it would be ideal to use DTOs when returning objects from the API. +Returning raw database objects as responses isn't really ideal (and I found an issue with many-to-many relationships which causes an infinite loop in the JSON parser!), so it would be ideal to use DTOs when returning objects from the API. ### More and better configuration