StevenJW/x-lab-lbq-technical-test
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update readme todos

Browse Source
This commit is contained in:
Stedoss 2022-11-01 20:21:15 +00:00
parent d17d9fd036
commit 45fef12590
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
README.md
View File

@ -111,6 +111,10 @@ There are three clear entities that could be split out into microservices (they
Only unit tests are included, which are good however integration and automated tests would be ideal for production software. Only unit tests are included, which are good however integration and automated tests would be ideal for production software.
### Pagination
Pagination is something that I've not really had a chance to look into (apart from a bit of it in Laravel), so it would have been nice to deal with it here to learn a bit more about it. And make the index page perform much nicer with the searches.
### DTOs ### DTOs
Returning raw database objects as responses isn't really ideal (and I found an issue with many-to-many relationships which causes an infinite loop in the JSON parser!), so it would be ideal to use DTOs when returning objects from the API. Returning raw database objects as responses isn't really ideal (and I found an issue with many-to-many relationships which causes an infinite loop in the JSON parser!), so it would be ideal to use DTOs when returning objects from the API.
@ -132,7 +136,3 @@ More for the frontend, but backend doesn't have the best either. More checks mak
### Add unit tests for FE ### Add unit tests for FE
Even if it's just a few, it will show off how I unit test for the frontend. Even if it's just a few, it will show off how I unit test for the frontend.
### Cors?
Cors may be an issue here.