From 2a920ae85fc2c556bdbb2abe89553b1a0c011f64 Mon Sep 17 00:00:00 2001 From: Stedoss <29103029+Stedoss@users.noreply.github.com> Date: Tue, 1 Nov 2022 23:07:26 +0000 Subject: [PATCH] Fix tests --- README.md | 2 +- .../Controllers/VenueControllerTests.cs | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index 5784d9e..f333d9b 100644 --- a/README.md +++ b/README.md @@ -58,7 +58,7 @@ dotnet ef database update Data seeding is something I've done in projects before (usually through EF migrations), however it seemed to have issues with test data and testing scenario constants (particularly using an in-memory database). Feel free to checkout the seed data migration commit [here](https://github.com/Stedoss/x-lab-lbq/commit/add80a3521495445f9e5abb9cfe399c80d28e6c7) to see what the seeded migration looks like. -The database should seed automatically when launched for the first time, if compiled with the `LBQ_SEED_DATA` constant. It will read the `leedsbeerquest.csv` from the `LeedsBeerQuest.API` directory. It will only seed the database with the CSV data if there is no existing data in the database. +The database should seed automatically when launched for the first time, if compiled with the `LBQ_SEED_DATA` constant. It will read the `leedsbeerquest.csv` from the `LeedsBeerQuest.API` directory. It will only seed the database with the CSV data if there is no existing data in the database. The CSV location can be configured in `appsettings.json` at `Database:Seed:SeedDataLocation`. #### Running diff --git a/backend/LeedsBeerQuest.API/LeedsBeerQuest.API.Tests/Controllers/VenueControllerTests.cs b/backend/LeedsBeerQuest.API/LeedsBeerQuest.API.Tests/Controllers/VenueControllerTests.cs index 77f2665..d40e26d 100644 --- a/backend/LeedsBeerQuest.API/LeedsBeerQuest.API.Tests/Controllers/VenueControllerTests.cs +++ b/backend/LeedsBeerQuest.API/LeedsBeerQuest.API.Tests/Controllers/VenueControllerTests.cs @@ -29,9 +29,9 @@ public class VenueControllerTests [Test] public async Task GetAll_ReturnsOk_WithAllVenues_WhenNoVenueIdIsPassed() { - _venueService.GetAllVenues().Returns(TestData.VenueTestData); + _venueService.GetFilteredVenues().Returns(TestData.VenueTestData); - var result = await _venueController.GetAll(); + var result = await _venueController.GetVenues(); var resultValue = ControllerTestHelper.ActionResultToOkResultValue>(result); Assert.NotNull(resultValue);